for loop wget directory creation error

Question

As a Ubuntu beginner. I am trying to download links from multiple text files with wget2 in batch. The -P "$f" creates directory name with .txt suffix. Is it possible to ignore .txt for -P "$f". Any modification suggestions.

for f in *.txt;do wget2 -i "$f" -P "$f";done

score 3 · Answer 1 · edited Mar 27 '21 at 09:22

3

I think the most elegant way in bash is to use basename:

$(basename "$filename" "$suffix")

Your script becomes:

for f in *.txt;do wget2 -i "$f" -P "$(basename "$f" .txt)";done

source

edited Mar 27 '21 at 09:22

Kamil Maciorowski

74,068

answered Mar 27 '21 at 06:45

agtoever

6,272

1

Did you copy that from a blog? Those smart quotes around “$f” will come through to the output. – Michael Harvey Mar 27 '21 at 09:01
1

Removes quotes. Added source. – agtoever Mar 27 '21 at 09:10
It wasn't the quotes as such, it was the 66 - 99 style quotes that blog software often forces even on code. – Michael Harvey Mar 27 '21 at 09:12
Ah. Right. So the quotes should be there, right. If spaces are present in the filename... – agtoever Mar 27 '21 at 09:13

score 0 · Accepted Answer · answered Mar 27 '21 at 10:47

0

${f%.txt} expands like $f but with .txt suffix (if any) removed. Don't forget to double-quote it like you correctly quoted $f.

for f in *.txt; do wget2 -i "$f" -P "${f%.txt}"; done

The syntax is portable, it takes a pattern (like filename generation a.k.a. globbing pattern, not a regex). E.g. ${f%.*} gives you everything but the extension, no matter what the extension is. Here the dot is literal and the asterisk is a wildcard.

POSIX specifies few features like this. Bash supports them and more. Documentation:

POSIX
Bash

answered Mar 27 '21 at 10:47

Kamil Maciorowski

74,068

Why the downvote? – Kamil Maciorowski Mar 27 '21 at 15:32
This is the solution – Roxion Mar 30 '21 at 09:08

for loop wget directory creation error

2 Answers2

Linked