strange caption numbers in cross-references and list-of-figures

Question

I am trying to fit a large figure containing four subfigures into my document. The whole thing is close to a page break, so I decided to split the figure via \ContinuedFloat. So just in case the second half of it can be moved to the next page.

The caption of the large figure with the subfigures is used as a kind of headline and placed on top. The subfigures get captions at the bottom, as well as the next, smaller figure. That is working fine so far.

But the numbers are a mess. The cross-references show, that the subfigures are numbered as "2a" instead of "1a" and so on. The following figure is then "3" instead" of "2". And the list-of-figures displays wrong page numbers for the first two subfigures.

This shows the current situation:

\documentclass{scrreprt}

\usepackage[utf8]{inputenc}

\usepackage[list=true,listformat=simple]{subcaption}
    \captionsetup{font=small,labelfont=bf,singlelinecheck=false,within=none}

\usepackage[demo]{graphicx}

\usepackage{cleveref}
    \newcommand{\see}[1]{\cref{#1}, \cpageref{#1}}
    \newcommand{\sees}[2]{\crefrange{#1}{#2}, \cpagerefrange{#1}{#2}}

\begin{document}
There ist a huge amount of text, but I omitted it, because I was too lazy to type so many sentences.\par
There is some text and more text.\par

\begin{figure}[h]
    \caption[short heading for the figure with subfigures]{Something like a heading for this figure containing subfigures}
    \label{fig:1}
    \vspace{1eM}
\subcaptionbox[short caption, first subfigure]{long caption, first subfigure\label{fig:1A}}{\includegraphics[height=7cm]{ExampleA.jpg}}
    \hfill
\subcaptionbox[short caption, second subfigure]{long caption, second subfigure\label{fig:1B}}{\includegraphics[height=7cm]{ExampleB.jpg}}
\end{figure}

\begin{figure}[h]
    \ContinuedFloat
\subcaptionbox[short caption, third subfigure]{long caption, third subfigure\label{fig:1C}}{\includegraphics[height=7cm]{ExampleC.jpg}}
    \hfill
\subcaptionbox[short caption, fourth subfigure]{long caption, fourth subfigure\label{fig:1D}}{\includegraphics[height=7cm]{ExampleD.jpg}}
\end{figure}

Here is some text in between all these figures. 
\begin{figure}[h]
    \includegraphics[width=7cm]{Example2.jpg}
    \caption{a figure with a wrong number}
    \label{fig:2}
\end{figure}

At the end there are some cross-references to these pictures. Since they are floating, it is not really at the end, but that is tolerable for now.\\
\see{fig:1}\\
\see{fig:1A}\\
\see{fig:1D}\\
\see{fig:2}\\
\sees{fig:1A}{fig:1D}\\
\sees{fig:1}{fig:2}\\
\listoffigures
\end{document}

I tried to manage it via \phantomcaption and by redefining the position of the first caption. But since I am completely unaware of what is going on in the background I can't figure it out on my own. I'd really appreciate some help...

Answer 1

With a KOMA-Script class use \captionabove inside a group and remove \vspace{1em}:

\begingroup
  \captionabove
    [short heading for the figure with subfigures]
    {Something like a heading for this figure containing subfigures}%
    \label{fig:1}%
\endgroup

Code:

\documentclass{scrreprt}
\usepackage[utf8]{inputenc}
\usepackage[list=true,listformat=simple]{subcaption}
  \captionsetup{font=small,labelfont=bf,singlelinecheck=false,within=none}
\usepackage[demo]{graphicx}
\usepackage{cleveref}
  \newcommand{\see}[1]{\cref{#1}, \cpageref{#1}}
  \newcommand{\sees}[2]{\crefrange{#1}{#2}, \cpagerefrange{#1}{#2}}

\begin{document}
There ist a huge amount of text, but I omitted it, because I was too lazy to type so many sentences.\par
There is some text and more text.\par

\begin{figure}[ht]
  \begingroup
    \captionabove
      [short heading for the figure with subfigures]
      {Something like a heading for this figure containing subfigures}%
      \label{fig:1}%
  \endgroup
  \subcaptionbox
    [short caption, first subfigure]
    {long caption, first subfigure\label{fig:1A}}
    {\includegraphics[height=7cm]{ExampleA.jpg}}
  \hfill
  \subcaptionbox
    [short caption, second subfigure]
    {long caption, second subfigure\label{fig:1B}}
    {\includegraphics[height=7cm]{ExampleB.jpg}}
\end{figure}

\begin{figure}[ht]
  \ContinuedFloat
  \subcaptionbox
    [short caption, third subfigure]
    {long caption, third subfigure\label{fig:1C}}
    {\includegraphics[height=7cm]{ExampleC.jpg}}
  \hfill
  \subcaptionbox
    [short caption, fourth subfigure]
    {long caption, fourth subfigure\label{fig:1D}}
    {\includegraphics[height=7cm]{ExampleD.jpg}}
\end{figure}

Here is some text in between all these figures. 
\begin{figure}[ht]
  \includegraphics[width=7cm]{Example2.jpg}
  \caption{a figure with a wrong number}
  \label{fig:2}
\end{figure}

At the end there are some cross-references to these pictures. Since they are floating, it is not really at the end, but that is tolerable for now.\\
\see{fig:1}\\
\see{fig:1A}\\
\see{fig:1D}\\
\see{fig:2}\\
\sees{fig:1A}{fig:1D}\\
\sees{fig:1}{fig:2}

\listoffigures
\end{document}

Addendum 2016-04-24 (by Axel Sommerfeldt)

Additional explanation why using \captionabove solves this issue:

The counter is usually incremented at \caption (and not at \begin{figure}). While this simple rule is fine having only usual captions, having sub-captions makes all of this more complex since one can have zero to N captions within a figure, and \subcaptionbox (or subfigure environment) must know to which \caption it belongs. Otherwise \ref to a sub-caption would give a wrong result, and the list entry in the List of Figures would be incorrect, too. So when having sub-captions, the figure (or table) counter get sometimes incremented at the caption and sometimes at the sub-caption. For a correct increment of the figure counter the sub-caption must know if it belongs to a main-caption in front of it, or a main-caption coming after it.

Regarding your case: \caption usually means \captionbelow in a document using a KOMA-Script class, and so the first \subcaptionbox increments the figure counter additionally, assuming it belongs to a (future) \caption coming after it. For that reason this will be fixed by using \captionabove instead of \caption (or \captionbelow): This way \subcaptionbox knows it belongs to the (past) \caption typeset in front of it, and this way it does not increment the figure counter anymore.

Answer 2

For a quick fix you can use \addtocounter{figure}{-1} right after the \caption call in your first float to ger the numbering right. In any case I recommend you to wrap this into some macro. Doing so, you are able to control every occurance of this fix at once. In my solution I called this macro \StartSubcaptionsFloat:

\newcommand{\StartSubcaptionsFloat}{\vspace{1em}\addtocounter{figure}{-1}}

As described you would then use it to mark the beginning of your subfigures, e.g.

\begin{figure}
  \caption[short heading for the figure with subfigures]
    {Something like a heading for this figure containing subfigures}
  \StartSubcaptionsFloat
  \subcaptionbox[short caption, first subfigure]
    {long caption, first subfigure\label{fig:1A}}
    {\includegraphics[height=7cm]{ExampleA.jpg}}
  \hfill
  \subcaptionbox[short caption, second subfigure]
    {long caption, second subfigure\label{fig:1B}}
    {\includegraphics[height=7cm]{ExampleB.jpg}}
  \label{fig:1}
\end{figure}

If you then want to disable the fix later on you can redefine \StartSubcaptionsFloat to be simply the \vspace adjust, i.e.

\newcommand{\StartSubcaptionsFloat}{\vspace{1em}}

Probabilly your better options are to either change the class as the problem is related to the KOMA classes or to issue \caption at the end of your float. I strongly recommend to go with the last option, i.e. to say

\begin{figure}
  \subcaptionbox[short caption, first subfigure]
    {long caption, first subfigure\label{fig:1A}}
    {\includegraphics[height=7cm]{ExampleA.jpg}}
  \hfill
  \subcaptionbox[short caption, second subfigure]
    {long caption, second subfigure\label{fig:1B}}
    {\includegraphics[height=7cm]{ExampleB.jpg}}
  \caption[short heading for the figure with subfigures]
    {Something like a heading for this figure containing subfigures}
  \label{fig:1}
\end{figure}

as 1) you placed the captions below images in single floats (so it's a matter of consistency), 2) you should not mess with changing the class near the dealine and 3) it's defenetely the cleanest solution.

Addendum

See the answer by @esdd for a clean solution within KOMA.