To me, \newcommand and editor keybindings have nearly completely different use-cases.
I would define a \newcommand because it improves the semantics of my document, or gives me flexibility to change design in the future. Never (or at least nearly never) to save typing.
I certainly will, however, use my editor to save me typing. A well-constructed LaTeX editor, or plugin to an editor like Vim, will mostly have already defined many that are useful. I don't think this is some special Vim-magic: there are good LaTeX modes or plug-ins for lots of editors. See this question for a big list (That's not a dig at Vim, just doubting that there is anything inherently faster, in the hands of an experienced user, about it, compared to other good editors. And speed in Vim does critically depend on taking the time to learn how to use it.)
When you start out with LaTeX, however, often your speed is not dependent on how quickly you can type, but on how quickly you can think what you need to do to achieve something. Especially when the typesetting gets complicated (and accuracy matters), as it does with formulae. If you add the mental load of learning a new and idiosyncratic editor and a raft of keybindings (so now you have to remember both the command you want and the keybinding you want) you may end up going slower, at least in the short term.
(FWIW, I don't think LaTeX is well designed for taking speedy live notes, even if some people manage to do that. That's not its main aim. But I'm pretty confident that those who are speedy are speedy because they have spent lots of time doing it. There's no magic bullet.)
\newcommands. If you ever share your file with a collaborator and everybody has their own macros, the hell breaks loose, Use key board short cuts and standard commands. (You can find answers here which are IMHO rather questionable practice, such as, say,\newcommand{\ul}{...}even though\ulis a command in thesoulpackage, which is a sort of standard package. So I recommend avoiding those things as much as possible.) – Apr 30 '20 at 22:15