\usepackage{fontawesome} Double symbols in List of Figures

Question

When using (see aswer https://tex.stackexchange.com/a/102724/67761 from the question "Symbol for external links"):

\documentclass{article}
\usepackage{fontawesome}
\usepackage[hidelinks]{hyperref}

% Redefinition, symbol included in link:
\let\orighref\href
\renewcommand{\href}[2]{\orighref{#1}{#2\,\faExternalLink}}

\begin{document}
\href{http://example.com}{example web site}
\end{document}

To achieve a special symbol after an external URL, everything works fine. I can compile this with simple LaTeX.

An external URL in a \captionof{figure}{ABC. See \href{https://DEF}{GHI}.} also works fine and shows the symbol.

Works fine:

The problem is when you add

\tableofcontents*
\listoffigures

Then suddenly in the List of Figures, the symbols are double!

See here the problem:

Answer 1

Don't redefine hyperref commands like this. At first they should be robust (so that you don't end with doublettes like with your redefinition), and at second hyperref tries hard to handle special symbols in the url and you are deactivating this.

You can define your own href command like this:

\documentclass{article}
\usepackage{fontawesome}
\usepackage{caption}
\usepackage[hidelinks]{hyperref}

% Redefinition, symbol included in link:
\makeatletter
\DeclareRobustCommand*{\newhref}{\hyper@normalise\newhref@}
\newcommand\newhref@[2]{\hyper@linkurl{#2\,\faExternalLink}{#1}}
\makeatother
\begin{document}
\listoffigures

\captionof{figure}{ABC. See \newhref{https://DEF}{GHI}.}

\newhref{http://example.com}{example web site}

\end{document}